Port #[non_exhaustive] to the new attribute parsing infrastructure
#143085
+88
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_attr_data_structures |
JonathanBrouwer
commented
Jun 27, 2025
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
non_exhaustive_parser
branch
from
9e04a8b to
419f4e3
Compare
9 tasks
|
r? @oli-obk |
JonathanBrouwer
force-pushed
the
non_exhaustive_parser
branch
from
419f4e3 to
7558b4b
Compare
|
^ Rebased |
|
☔ The latest upstream changes (presumably #143338) made this pull request unmergeable. Please resolve the merge conflicts. |
JonathanBrouwer
force-pushed
the
non_exhaustive_parser
branch
from
7558b4b to
c7d81ea
Compare
|
@rustbot blocked |
rustbot
added
S-blocked
|
☔ The latest upstream changes (presumably #143363) made this pull request unmergeable. Please resolve the merge conflicts. |
JonathanBrouwer
force-pushed
the
non_exhaustive_parser
branch
from
c7d81ea to
a494898
Compare
|
^ Rebased on master |
rustbot
added
S-waiting-on-review
|
|
|
The other pr is in the queue rn, can review soon |
JonathanBrouwer
force-pushed
the
non_exhaustive_parser
branch
from
a494898 to
027126c
Compare
|
@jdonszelmann Rebased on the other PR |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 4, 2025
…ser, r=jdonszelmann Port `#[non_exhaustive]` to the new attribute parsing infrastructure Ports `non_exhaustive` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`
bors
added a commit
that referenced
this pull request
Jul 4, 2025
Rollup of 9 pull requests Successful merges: - #141532 (std: sys: net: uefi: tcp4: Implement write) - #143085 (Port `#[non_exhaustive]` to the new attribute parsing infrastructure) - #143298 (`tests/ui`: A New Order [23/N]) - #143372 (Remove names_imported_by_glob_use query.) - #143386 (Assign dependency bump PRs to me) - #143406 (Remove some unnecessary `unsafe` in VecCache) - #143408 (mbe: Gracefully handle macro rules that end after `=>`) - #143414 (remove special-casing of boxes from match exhaustiveness/usefulness analysis) - #143444 (clean up GVN TypeId test) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jul 4, 2025
Rollup of 8 pull requests Successful merges: - #141532 (std: sys: net: uefi: tcp4: Implement write) - #143085 (Port `#[non_exhaustive]` to the new attribute parsing infrastructure) - #143372 (Remove names_imported_by_glob_use query.) - #143386 (Assign dependency bump PRs to me) - #143406 (Remove some unnecessary `unsafe` in VecCache) - #143408 (mbe: Gracefully handle macro rules that end after `=>`) - #143414 (remove special-casing of boxes from match exhaustiveness/usefulness analysis) - #143444 (clean up GVN TypeId test) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 5, 2025
Rollup merge of #143085 - JonathanBrouwer:non_exhaustive_parser, r=jdonszelmann Port `#[non_exhaustive]` to the new attribute parsing infrastructure Ports `non_exhaustive` to the new attribute parsing infrastructure for #131229 (comment) r? ``@jdonszelmann``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports
non_exhaustiveto the new attribute parsing infrastructure for #131229 (comment)r? @jdonszelmann